Skip to content

Conversation

@jeffw16
Copy link
Member

@jeffw16 jeffw16 commented Oct 26, 2025

Using the coding conventions pages here:

Defined GitHub Copilot instructions files.

Copilot AI review requested due to automatic review settings October 26, 2025 04:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub Copilot instruction files to establish coding conventions for the MediaWiki codebase. These files translate MediaWiki's official coding conventions into a format that GitHub Copilot can use to provide context-aware assistance when working with PHP and other file types in the repository.

Key changes include:

  • Comprehensive PHP coding conventions covering code structure, naming, pitfalls, and best practices
  • General MediaWiki conventions applicable to all file types
  • Extension-specific best practices for MediaWiki extensions

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/instructions/php.instructions.md Defines comprehensive PHP coding conventions including spacing, bracing, naming conventions, type declarations, and documentation standards
.github/instructions/mediawiki.instructions.md Establishes general conventions for file formatting, indentation, naming, documentation, and message handling across all file types
.github/instructions/mediawiki-extensions.instructions.md Specifies best practices for MediaWiki extension development including architecture, file structure, database usage, and security

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeffw16 jeffw16 merged commit 1090a09 into main Oct 26, 2025
17 checks passed
@jeffw16 jeffw16 deleted the jeffw16/coding-conventions branch October 26, 2025 04:04
jeffw16 added a commit that referenced this pull request Oct 26, 2025
* Add coding conventions

* Add applyTo for PHP instructions

* Add extension-specific coding standards
jeffw16 added a commit that referenced this pull request Oct 26, 2025
* Special:MobileDiff

* Add coding conventions files for GitHub Copilot (#11)

* Add coding conventions

* Add applyTo for PHP instructions

* Add extension-specific coding standards

* Refactoring

* Update tests/phpunit/stubs.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/phpunit/stubs.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/phpunit/stubs.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix stub issue

* Fix code styles

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants